Fix assertion failures resulting in crashes with stream filter object parameters #20500
+65
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… parameters This works for dynamic props but not for non-dynamic props due to the missing INDIRECT handling.
Girgias
approved these changes
Nov 16, 2025
|
|
||
| if (Z_TYPE_P(filterparams) == IS_ARRAY || Z_TYPE_P(filterparams) == IS_OBJECT) { | ||
| if ((tmpzval = zend_hash_str_find(HASH_OF(filterparams), "blocks", sizeof("blocks")-1))) { | ||
| HashTable *ht = HASH_OF(filterparams); |
|
|
||
| ?> | ||
| --EXPECT-- | ||
| Hallo wereld hopelijk niet kapot |
Member
There was a problem hiding this comment.
Keep it in English please, although this is funny (at least to me)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works for dynamic props but not for non-dynamic props due to the missing INDIRECT handling.
As a side note: We need to get this working anyway if we ever want to move from arrays to typed objects for filter parameters and filters APIs.